From 92a49274860f58aa0904f2d41d5238baf84e8780 Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Sun, 30 Nov 2003 01:23:44 +0000
Subject: [PATCH] Sanity check hideminor param; fix the hide link in rc

---
 includes/SpecialRecentchanges.php       | 24 ++++++++++++------------
 includes/SpecialRecentchangeslinked.php |  1 +
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/includes/SpecialRecentchanges.php b/includes/SpecialRecentchanges.php
index 74282bb2b7..1e3a93de3f 100644
--- a/includes/SpecialRecentchanges.php
+++ b/includes/SpecialRecentchanges.php
@@ -49,25 +49,25 @@ function wfSpecialRecentchanges( $par )
 	if ( ! isset( $hideminor ) ) {
 		$hideminor = $wgUser->getOption( "hideminor" );
 	}
+	$hideminor = ($hideminor ? 1 : 0);
 	if ( $hideminor ) {
 		$hidem = "AND rc_minor=0";
-                $mltitle = wfMsg( "show" );
-                $mlhide = 0;
-
+		$mltitle = wfMsg( "show" );
+		$mlhide = 0;
 	} else {
 		$hidem = "";
-                $mltitle = wfMsg( "hide" );
-                $mlhide = 1;
+		$mltitle = wfMsg( "hide" );
+		$mlhide = 1;
 	}
 
-        if ( isset( $from ) ) {
-          $mlparams = "from={$from}&hideminor={$mlhide}";
-        } else {
-          $mlparams = "days={$days}&limit={$limit}&hideminor=0";
-        }
+	if ( isset( $from ) ) {
+		$mlparams = "from={$from}&hideminor={$mlhide}";
+	} else {
+		$mlparams = "days={$days}&limit={$limit}&hideminor={$mlhide}";
+	}
 
-        $mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchanges" ),
-                                     $mltitle, $mlparams );
+	$mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchanges" ),
+		$mltitle, $mlparams );
 	
 	if ( !isset( $hidebots ) ) {
 		$hidebots = 1;
diff --git a/includes/SpecialRecentchangeslinked.php b/includes/SpecialRecentchangeslinked.php
index af30777ff4..b2c568e462 100644
--- a/includes/SpecialRecentchangeslinked.php
+++ b/includes/SpecialRecentchangeslinked.php
@@ -28,6 +28,7 @@ function wfSpecialRecentchangeslinked( $par = NULL )
 	list( $limit, $offset ) = wfCheckLimits( 100, "rclimit" );
 	$cutoff = wfUnix2Timestamp( time() - ( $days * 86400 ) );
 
+	$hideminor = ($hideminor ? 1 : 0);
 	if ( $hideminor ) {
 		$mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchangeslinked" ),
 	  	  WfMsg( "show" ), "target=" . wfEscapeHTML( $nt->getPrefixedURL() ) .
-- 
2.20.1